Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing lowercasing protocol to avoid changins at plans againsts loa… #4631

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Removing lowercasing protocol to avoid changins at plans againsts loa… #4631

merged 1 commit into from
Oct 29, 2019

Conversation

marioanton
Copy link
Contributor

@marioanton marioanton commented Oct 16, 2019 •
edited
Loading

Removing lowercasing protocol function to avoid changes at plans against load balancer rules and probes

This sorts out two diff issues:
resource_arm_loadbalancer_probe

    Resource ID: azurerm_lb_probe.probe.2
    Mismatch reason: attribute mismatch: protocol
    Diff One (usually from plan): *terraform.InstanceDiff{mu:sync.Mutex{state:0, sema:0x0}, Attributes:map[string]*terraform.ResourceAttrDiff{"protocol":*terraform.ResourceAttrDiff{Old:"Tcp", New:"tcp", NewComputed:false, NewRemoved:false, NewExtra:"tcp", RequiresNew:false, Sensitive:false, Type:0x0}}, Destroy:false, DestroyDeposed:false, DestroyTainted:false, Meta:map[string]interface {}(nil)}
    Diff Two (usually from apply): *terraform.InstanceDiff{mu:sync.Mutex{state:0, sema:0x0}, Attributes:map[string]*terraform.ResourceAttrDiff(nil), Destroy:false, DestroyDeposed:false, DestroyTainted:false, Meta:map[string]interface {}(nil)}

Also include as much context as you can about your config, state, and the steps you performed to trigger this error.

and

resource_arm_loadbalancer_rule

  ~ azurerm_lb_probe.probe[2]
      protocol:                                                  "Tcp" => "tcp"
....

@ghost ghost added the size/XS label Oct 16, 2019
tombuildsstuff
tombuildsstuff approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @marioanton

Thanks for this PR - taking a look through this LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff added this to the v1.37.0 milestone Oct 29, 2019
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-10-29 at 15 28 46

@tombuildsstuff tombuildsstuff merged commit a49cd94 into hashicorp:master Oct 29, 2019
tombuildsstuff added a commit that referenced this pull request Oct 29, 2019
@tombuildsstuff
updating to include #4631
d871da1
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 28, 2019
@mariobede mariobede deleted the BUG/SanitizationForLBProtocol_removed branch November 28, 2019 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement service/load-balancers size/XS
Projects
None yet
Milestone
v1.37.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marioanton @tombuildsstuff @mariobede